Ability to write migration custom logic in Go #187
Conversation
|
@rubenv could you please review? |
|
So one reason I never added this was because it basically brakes CLI usage. Not sure what to do with this. |
Writing migrations in Go ( For me, it's okay if the library will provide advanced functionality that is needed for projects in which the migration logic cannot be implemented in just SQL. The choice of how to write and run migrations will be up to the developer. I don't see any real problem here. Please correct me if I'm wrong, miss something, or misunderstood your comment. |
|
@rubenv could you please clarify if there is a chance to continue the discussion? Or is it your final decision and fork is the only way for us? |
|
It's ok, we'll get this in. I just haven't found the time to review/merge
this: out second kid has just been born and I more or less lost track of
this PR.
I'll get back to it, ping me in a bit if I forget.
And apologies for the delay!
…On Tue, Feb 2, 2021, 12:41 Vasiliy Tsybenko ***@***.***> wrote:
@rubenv <https://github.com/rubenv> could you please clarify if there is
a chance to continue the discussion? Or is it your final decision and fork
is the only way for us?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKPGHM5IKCFA636PF3V3DS47QHNANCNFSM4WLBYLPQ>
.
|
|
No problem, this is a very important and good event! Сongratulations!:) |
| "github.com/go-gorp/gorp/v3" | ||
| "github.com/gobuffalo/packr/v2" | ||
| _ "github.com/mattn/go-sqlite3" | ||
| . "gopkg.in/check.v1" | ||
| "gopkg.in/gorp.v1" |
There was a problem hiding this comment.
I'm not sure we can do this. Sadly gorp ended up as part of the public API and I guess this will break things for people that depend on it?
There was a problem hiding this comment.
Mind you, we should probably upgrade, but I don't want to break peoples code if we can avoid it.
Sometimes it's needed to write custom logic (usually for data migration, not scheme) in Go during migration. Please consider this change.